← Back to team overview

ubuntu-phone team mailing list archive

Re: Question about off-topic comments in core-apps code

 

Hello,

I'm very sorry if that comment offended you in any way. I'd be happy to
remove that if Canonical wants, but let me point out several things about
that code.

First, that code was not written for Canonical or the File Manager. It was
written for a PERSONAL library of mine called ubuntu-ui-extras (
https://github.com/iBeliever/ubuntu-ui-extras), specifically for a Bible
application I'm developing called uBible.

In that context, the comment makes perfect sense. BibleTime, a Gtk Bible
program, has a similar comment in its header.

Secondly, that comment is not advertising or such - it is part of the
header, just like the license is, and is there as a reminder for myself and
other Bible-believing developers to use our talents for God's glory.

Thirdly, I checked with Alan Pope and he said to leave the original license
in since it was taken from a library, though I do not think he read the
actual license header.

Once again, I'm very sorry if that comment offended you in any way and I
can remove that if Canonical wants.

Thanks,
Michael Spencer


On Mon, Feb 3, 2014 at 6:58 AM, Michel RENON <renon@xxxxxxxxxxxxxxxxx>wrote:

> Hi,
>
> I noticed a comment in a source file of some core apps :
> http://bazaar.launchpad.net/~ubuntu-filemanager-dev/ubuntu-
> filemanager-app/trunk/view/head:/VerticalDivider.qml, lines 2:4.
> It's obvious that such comment is completely off-topic in a source code,
> specially when it's an open-source app under the responsibility of an
> international company.
>
> I was wondering if it's ok to accept such kind of comments : is there any
> rule/policy that handle such case?
>
> If we look in the long term, allowing such comments may result in anyone
> writing any kind of comments : some personal humour, some political
> opinion, some advertising and finally some span ("enlarge your code !" ;-)
> sorry, couldn't resist !)
>
> Do you remember that months ago, Microsoft had to officially apologize for
> a simple constant in a source file ? (1). So I think Canonical should
> prevent that kind of problem.
>
>
> Regards,
> Michel
>
>
>
> (1) http://www.forbes.com/sites/adriankingsleyhughes/2012/07/
> 21/microsoft-removes-embarrassing-big-boobs-string-from-linux-code/
>
> --
> Mailing list: https://launchpad.net/~ubuntu-phone
> Post to     : ubuntu-phone@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~ubuntu-phone
> More help   : https://help.launchpad.net/ListHelp
>



-- 
Michael Spencer | sonrisesoftware.wordpress.com

Trust in the Lord with all thine heart; and lean not unto thine own
understanding. In all thy ways acknowledge him, and he shall direct thy
paths.
- Proverbs 3:5-6

Follow ups

References