← Back to team overview

ubuntu-sdk-bugs team mailing list archive

[Bug 1214618] Re: apparmor policy_version is incorrectly set

 

Wow. I'm shocked that it can't do "1.0"-- python3 json didn't have any
problems (in fact, "float(1)" returns 1.0). Then I did some (cursory)
research and it turns out that "A floating-point number with a zero a
fractional part, such as 1.0, could reasonably be converted to the JSON
number 1 as well as 1.0; however no implementations choose to drop the
fractional part". Seems we found an implementation that did.

The background is that the security team discussed this to death and
there were people that felt the policy_version should be a string, but
float won out because tools wouldn't have to do anything special to do
numeric sorts and comparisons. It was a way to make sure the manifest
was a simple as possible for people, libraries, tools, etc. It was
deemed enough to have $major.$minor.

In that spirit, let's mark this bug as "Won't Fix" and I'll adjust
click-apparmor, apparmor and the review tools to allow "1" and we'll
tack on the .0.

** Changed in: qtcreator (Ubuntu Saucy)
       Status: Fix Committed => Won't Fix

-- 
You received this bug notification because you are a member of Ubuntu
SDK bug tracking, which is subscribed to qtcreator in Ubuntu.
https://bugs.launchpad.net/bugs/1214618

Title:
  apparmor policy_version is incorrectly set

Status in “qtcreator” package in Ubuntu:
  Fix Committed
Status in “qtcreator” source package in Saucy:
  Won't Fix

Bug description:
  The click manifest uses the following for policy_version:
                  "policy_version": 1

  This is invalid and the quick fix is to change this to:
                  "policy_version": 1.0

  The proper fix is that qtcreator should look for the highest version
  found in /usr/share/apparmor/easyprof/policygroups/ubuntu and use it.

  This could be extended to make is easier for users by performing:
  $ aa-easyprof --list-policy-groups --policy-vendor=ubuntu --policy-version=<highest version>

  to enumerate the policy groups and then shoving them into a combobox
  for users to use.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qtcreator/+bug/1214618/+subscriptions