← Back to team overview

ubuntu-sdk-bugs team mailing list archive

[Bug 1497147] [NEW] Network: Fix up previous corruption patch

 

Public bug reported:

(https://codereview.qt-project.org/#/c/120738)

Committed to all Qt stable series:

This is a fix-up for cff39fba10ffc10ee4dcfdc66ff6528eb26462d3.
That patch lead to some internal state issues that lead to the QTBUG-47048
or to QNetworkReply objects erroring with "Connection Closed" when
the server closed the Keep-Alive connection.

This patch changes the QNAM socket slot connections to be DirectConnection.
We don't close the socket anymore in slots where it is anyway in a closed state
afterwards. This prevents event/stack recursions.
We also flush QSslSocket/QTcpSocket receive buffers when receiving a disconnect
so that the developer always gets the full decrypted data from the buffers.

[ChangeLog][QtNetwork] Fix HTTP issues with "Unknown Error" and "Connection Closed"
[ChangeLog][QtNetwork][Sockets] Read OS/encrypted read buffers when connection
closed by server.

** Affects: qtbase-opensource-src (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
SDK bug tracking, which is subscribed to qtbase-opensource-src in
Ubuntu.
https://bugs.launchpad.net/bugs/1497147

Title:
  Network: Fix up previous corruption patch

Status in qtbase-opensource-src package in Ubuntu:
  New

Bug description:
  (https://codereview.qt-project.org/#/c/120738)

  Committed to all Qt stable series:

  This is a fix-up for cff39fba10ffc10ee4dcfdc66ff6528eb26462d3.
  That patch lead to some internal state issues that lead to the QTBUG-47048
  or to QNetworkReply objects erroring with "Connection Closed" when
  the server closed the Keep-Alive connection.

  This patch changes the QNAM socket slot connections to be DirectConnection.
  We don't close the socket anymore in slots where it is anyway in a closed state
  afterwards. This prevents event/stack recursions.
  We also flush QSslSocket/QTcpSocket receive buffers when receiving a disconnect
  so that the developer always gets the full decrypted data from the buffers.

  [ChangeLog][QtNetwork] Fix HTTP issues with "Unknown Error" and "Connection Closed"
  [ChangeLog][QtNetwork][Sockets] Read OS/encrypted read buffers when connection
  closed by server.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qtbase-opensource-src/+bug/1497147/+subscriptions


Follow ups