ubuntu-sdk-bugs team mailing list archive
-
ubuntu-sdk-bugs team
-
Mailing list archive
-
Message #05689
[Bug 1372530] Re: Button text color doesn't offer great contrast, and looks disabled when it's not
Just looked at the current design docs with kgunn's help.
It appears the common 'dark' text colour for light backgrounds Ubuntu
Design wants is #5D5D5D (but I personally think #888888 might look
better). So it's seemingly just the threshold we've got wrong in
ButtonStyle.qml:
textColor: ColorUtils.luminance(button.color) <= 0.85 && !(stroke &&
!button.pressed) ? "#FFFFFF" : "#888888"
should be more like:
textColor: ColorUtils.luminance(button.color) < 0.4 && !(stroke &&
!button.pressed) ? "#FFFFFF" : "#5D5D5D"
or (my personal suggestion):
textColor: ColorUtils.luminance(button.color) < 0.4 && !(stroke &&
!button.pressed) ? "#FFFFFF" : "#888888"
** Changed in: unity8 (Ubuntu)
Status: New => Invalid
--
You received this bug notification because you are a member of Ubuntu
SDK bug tracking, which is subscribed to ubuntu-ui-toolkit in Ubuntu.
https://bugs.launchpad.net/bugs/1372530
Title:
Button text color doesn't offer great contrast, and looks disabled
when it's not
Status in Ubuntu UX:
New
Status in ubuntu-ui-toolkit package in Ubuntu:
Triaged
Status in unity8 package in Ubuntu:
Invalid
Bug description:
I'll attach some pictures to show what I mean.
We have a visual design for the welcome wizard when you first turn on
the device (see attached design.jpg). It shows a combo box that is
hard to achieve with the current toolkit.
(As an aside, there is no joiner between the drop down button and the
rest of the widget in design.jpg. I don't know how to do that with
the current SDK... But that's not the point of this bug.)
My real problem is text color. By default, I get a kind of grey
background color and light text. It's not the easiest to see. And
this is the default! See default.png
When I set a white background to get closer to the visual design, I
still get a light text. Which is also hard to see. See white.png
I seem to have no control over the color of the text. In
ButtonStyle.qml, I see:
textColor: ColorUtils.luminance(button.color) <= 0.85 &&
!(stroke && !pressed) ? "#FFFFFF" : "#888888"
Which does not provide much control nor the possibility for a
particularly dark text color.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-ux/+bug/1372530/+subscriptions