ubuntu-sdk-bugs team mailing list archive

Thread
Date

[Bug 1626063] [NEW] OrientationHelper tests are useless

To: ubuntu-sdk-bugs@xxxxxxxxxxxxxxxxxxx
From: Tim Peeters <1626063@xxxxxxxxxxxxxxxxxx>
Date: Wed, 21 Sep 2016 12:11:42 -0000
Reply-to: Bug 1626063 <1626063@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

Public bug reported:

tst_orientation does not test that settings are actually effective,
because there is a QSKIP in there that skips the useful tests. It is
only tested that there are no warnings when initializing
OrientationHelper.

The test that follows the QSKIP is not valid because contentOrientation
(enum) is compared with orientationAngle (degrees). So that will fail
when QSKIP is removed. We need a proper test for the effectiveness of
the OrientationHelper, if we still use the OrientationHelper.

** Affects: ubuntu-ui-toolkit (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
SDK bug tracking, which is subscribed to ubuntu-ui-toolkit in Ubuntu.
https://bugs.launchpad.net/bugs/1626063

Title:
  OrientationHelper tests are useless

Status in ubuntu-ui-toolkit package in Ubuntu:
  New

Bug description:
  tst_orientation does not test that settings are actually effective,
  because there is a QSKIP in there that skips the useful tests. It is
  only tested that there are no warnings when initializing
  OrientationHelper.

  The test that follows the QSKIP is not valid because
  contentOrientation (enum) is compared with orientationAngle (degrees).
  So that will fail when QSKIP is removed. We need a proper test for the
  effectiveness of the OrientationHelper, if we still use the
  OrientationHelper.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1626063/+subscriptions