← Back to team overview

ubuntu-sdk-team team mailing list archive

Re: [Merge] lp:~artmello/ubuntu-ui-toolkit/ubuntu-ui-toolkit-clipboard-dbus into lp:ubuntu-ui-toolkit/staging

 

Review: Needs Information

> Component.onCompleted: textField.forceActiveFocus()

Hmmm I might've expected you to do this from the unit test (eg. QTest::keyClick(textField->window(), Qt::Key_Tab);)

And, too, you'll want to check that focus indeed there to avoid false negatives:

QTRY_COMPARE_WITH_TIMEOUT(textField->property("activeFocus").toBool(), true, 1000);

Is handling the base component good enough? If not, you might need to access the internal editor via its objectName text_input.
-- 
https://code.launchpad.net/~artmello/ubuntu-ui-toolkit/ubuntu-ui-toolkit-clipboard-dbus/+merge/314072
Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging.


References