ubuntu-sdk-team team mailing list archive

[Albert Astals Cid <albert.astals@xxxxxxxxxxxxx>]

Albert Astals Cid has proposed merging lp:~aacid/ubuntu-ui-toolkit/initialize_variable into lp:ubuntu-ui-toolkit/staging.

Commit message:
Fix conditional jump or move depends on uninitialised value(s)

    Valgrind says
    ==11560== Conditional jump or move depends on uninitialised value(s)
    ==11560== at 0x2D64BC9F: getVerticalPositioningMode (ucslotslayout.cpp:75)
    ==11560== by 0x2D64BC9F: UCSlotsLayoutPrivate::updateTopBottomPaddingIfNeeded() (ucslotslayout.cpp:82)
    ==11560== by 0x2D64CEA9: UCSlotsLayoutPrivate::_q_updateGuValues() (ucslotslayout.cpp:211)
    ==11560== by 0x2D64CEFA: UCSlotsLayoutPrivate::init() (ucslotslayout.cpp:50)
    ==11560== by 0x2D63DE88: UCListItemLayout::UCListItemLayout(QQuickItem*) (uclistitemlayout.cpp:353)
    ==11560== by 0x2D60037F: QQmlElement (qqmlprivate.h:99)
    ==11560== by 0x2D60037F: void QQmlPrivate::createInto<UCListItemLayout>(void*) (qqmlprivate.h:108)
    ==11560== by 0x6BD1C98: QQmlType::create() const (qqmlmetatype.cpp:746)
    ==11560== by 0x6C33F3B: QQmlObjectCreator::createInstance(int, QObject*, bool) (qqmlobjectcreator.cpp:1080)
    ==11560== by 0x6C3645E: QQmlObjectCreator::setPropertyBinding(QQmlPropertyData const*, QV4::CompiledData::Binding const*) (qqmlobjectcreator.cpp:776)
    ==11560== by 0x6C366C7: QQmlObjectCreator::setupBindings(QBitArray const&) (qqmlobjectcreator.cpp:728)
    ==11560== by 0x6C33655: QQmlObjectCreator::populateInstance(int, QObject*, QObject*, QQmlPropertyData const*, QBitArray const&) (qqmlobjectcreator.cpp:1355)
    ==11560== by 0x6C34236: QQmlObjectCreator::createInstance(int, QObject*, bool) (qqmlobjectcreator.cpp:1202)
    ==11560== by 0x6C34A55: QQmlObjectCreator::create(int, QObject*, QQmlInstantiationInterrupt*) (qqmlobjectcreator.cpp:204)


Requested reviews:
  ubuntu-sdk-build-bot (ubuntu-sdk-build-bot): continuous-integration
  Ubuntu SDK team (ubuntu-sdk-team)

For more details, see:
https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/initialize_variable/+merge/316135
-- 
Your team Ubuntu SDK team is requested to review the proposed merge of lp:~aacid/ubuntu-ui-toolkit/initialize_variable into lp:ubuntu-ui-toolkit/staging.

=== modified file 'src/UbuntuToolkit/ucslotslayout.cpp'
--- src/UbuntuToolkit/ucslotslayout.cpp	2016-10-07 14:33:47 +0000
+++ src/UbuntuToolkit/ucslotslayout.cpp	2017-02-01 16:11:23 +0000
@@ -32,6 +32,7 @@
     : QQuickItemPrivate()
     , mainSlot(Q_NULLPTR)
     , m_parentItem(Q_NULLPTR)
+    , mainSlotHeight(0)
     , maxSlotsHeight(0)
     , _q_cachedHeight(-1)
     , maxNumberOfLeadingSlots(1)