ubuntu-sdk-team team mailing list archive

[Christian Dywan <christian@xxxxxxxxxxxx>]

Christian Dywan has proposed merging lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/hideTheDelegate into lp:ubuntu-ui-toolkit/staging.

Commit message:
ListItemPopover delegate should (in)visible as per action

Requested reviews:
  Ubuntu SDK team (ubuntu-sdk-team)
Related bugs:
  Bug #1662220 in ubuntu-ui-toolkit (Ubuntu): "[ListItem] Popupmenu shows traces of disabled actions"
  https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1662220

For more details, see:
https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/hideTheDelegate/+merge/316545
-- 
Your team Ubuntu SDK team is requested to review the proposed merge of lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/hideTheDelegate into lp:ubuntu-ui-toolkit/staging.

=== modified file 'src/imports/Components/1.3/ListItemPopover.qml'
--- src/imports/Components/1.3/ListItemPopover.qml	2015-07-01 12:06:34 +0000
+++ src/imports/Components/1.3/ListItemPopover.qml	2017-02-07 10:54:36 +0000
@@ -24,6 +24,7 @@
     contentWidth: units.gu(25)
 
     delegate: ListItem {
+        visible: action.visible
         contentItem.anchors {
              leftMargin: units.gu(2)
              rightMargin: units.gu(2)