ubuntu-sdk-team team mailing list archive

[Christian Dywan <christian@xxxxxxxxxxxx>]

Christian Dywan has proposed merging lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/hiddenWindowPopup into lp:ubuntu-ui-toolkit/staging.

Commit message:
Add unit test case opening popup before showing window

Requested reviews:
  Ubuntu SDK team (ubuntu-sdk-team)
Related bugs:
  Bug #1664620 in webbrowser-app (Ubuntu): "[regression] webbrowser_app.tests.test_basic_authentication fail with latest UITK"
  https://bugs.launchpad.net/ubuntu/+source/webbrowser-app/+bug/1664620

For more details, see:
https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/hiddenWindowPopup/+merge/317530
-- 
Your team Ubuntu SDK team is requested to review the proposed merge of lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/hiddenWindowPopup into lp:ubuntu-ui-toolkit/staging.

=== modified file 'tests/unit/visual/tst_popups_dialog.13.qml'
--- tests/unit/visual/tst_popups_dialog.13.qml	2017-01-05 14:11:37 +0000
+++ tests/unit/visual/tst_popups_dialog.13.qml	2017-02-16 17:29:08 +0000
@@ -34,6 +34,22 @@
     }
 
     UbuntuTestCase {
+        id: hiddenTest
+        name: "Popups.Dialog.Hidden"
+
+        property bool dialogDestroyed: false
+
+        function test_dismiss_dialog_no_focus_window_bug1664620() {
+            verify(!hiddenTest.windowShown);
+            var dlg = PopupUtils.open(dialog);
+            waitForRendering(dlg);
+            dlg.Component.destruction.connect(function() { hiddenTest.dialogDestroyed = true });
+            keyClick(Qt.Key_Escape);
+            tryCompare(hiddenTest, "dialogDestroyed", true, 500, "Dialog not destroyed");
+        }
+    }
+
+    UbuntuTestCase {
         id: test
         name: "Popups.Dialog"
         when: windowShown