ubuntu-sdk-team team mailing list archive

[Albert Astals Cid <albert.astals@xxxxxxxxxxxxx>]

Albert Astals Cid has proposed merging lp:~aacid/ubuntu-ui-toolkit/fix_ucstylehints_leak into lp:ubuntu-ui-toolkit/staging.

Commit message:
Fix memory leak in UCStyleHints


Requested reviews:
  Ubuntu SDK team (ubuntu-sdk-team)

For more details, see:
https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/fix_ucstylehints_leak/+merge/318478

Without this i get warnings in valgrind about leaking PropertyChange's
-- 
Your team Ubuntu SDK team is requested to review the proposed merge of lp:~aacid/ubuntu-ui-toolkit/fix_ucstylehints_leak into lp:ubuntu-ui-toolkit/staging.

=== modified file 'src/UbuntuToolkit/ucstylehints.cpp'
--- src/UbuntuToolkit/ucstylehints.cpp	2016-09-12 09:03:50 +0000
+++ src/UbuntuToolkit/ucstylehints.cpp	2017-02-28 13:36:12 +0000
@@ -273,6 +273,7 @@
 
         newBinding->setTarget(change->property());
         PropertyChange::setBinding(change, newBinding);
+        m_propertyBackup << change;
     }
 }