ubuntu-sdk-team team mailing list archive

[Christian Dywan <christian@xxxxxxxxxxxx>]

Christian Dywan has proposed merging lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/layoutMirroringEnabledInMainView into lp:ubuntu-ui-toolkit/staging.

Commit message:
Move LayoutMirroring.enabled from components to MainView

Requested reviews:
  Ubuntu SDK team (ubuntu-sdk-team)

For more details, see:
https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/layoutMirroringEnabledInMainView/+merge/319669

Inspired by: https://code.launchpad.net/~zsombi/ubuntu-ui-toolkit/mainview-rtl/+merge/251420
-- 
Your team Ubuntu SDK team is requested to review the proposed merge of lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/layoutMirroringEnabledInMainView into lp:ubuntu-ui-toolkit/staging.

=== modified file 'src/imports/Components/1.3/MainView.qml'
--- src/imports/Components/1.3/MainView.qml	2016-09-21 12:25:51 +0000
+++ src/imports/Components/1.3/MainView.qml	2017-03-13 10:06:06 +0000
@@ -105,6 +105,10 @@
     /*! \deprecated */
     property bool automaticOrientation: false
 
+    LayoutMirroring.enabled: Qt.application.layoutDirection == Qt.RightToLeft
+    LayoutMirroring.childrenInherit: true
+
+
     /*!
       \internal
       Use default property to ensure children added do not draw over the header.

=== modified file 'src/imports/Components/1.3/TextArea.qml'
--- src/imports/Components/1.3/TextArea.qml	2017-01-26 18:03:44 +0000
+++ src/imports/Components/1.3/TextArea.qml	2017-03-13 10:06:06 +0000
@@ -781,9 +781,6 @@
         }
     }
 
-    LayoutMirroring.enabled: Qt.application.layoutDirection == Qt.RightToLeft
-    LayoutMirroring.childrenInherit: true
-
     QtObject {
         id: internal
         // public property locals enabling aliasing

=== modified file 'src/imports/Components/1.3/TextField.qml'
--- src/imports/Components/1.3/TextField.qml	2017-02-21 00:17:06 +0000
+++ src/imports/Components/1.3/TextField.qml	2017-03-13 10:06:06 +0000
@@ -868,9 +868,6 @@
         }
     }
 
-    LayoutMirroring.enabled: Qt.application.layoutDirection == Qt.RightToLeft
-    LayoutMirroring.childrenInherit: true
-
     // grab clicks from the area between the frame and the input
     MouseArea {
         anchors.fill: parent

=== modified file 'src/imports/Components/ListItems/1.3/Empty.qml'
--- src/imports/Components/ListItems/1.3/Empty.qml	2016-01-27 15:17:56 +0000
+++ src/imports/Components/ListItems/1.3/Empty.qml	2017-03-13 10:06:06 +0000
@@ -174,9 +174,6 @@
     // Keep compatible with the old version
     height: implicitHeight
 
-    LayoutMirroring.enabled: Qt.application.layoutDirection == Qt.RightToLeft
-    LayoutMirroring.childrenInherit: true
-
     /*! \internal */
     QtObject {
         id: priv

=== modified file 'src/imports/Components/Popups/1.3/PopupBase.qml'
--- src/imports/Components/Popups/1.3/PopupBase.qml	2017-01-05 14:11:37 +0000
+++ src/imports/Components/Popups/1.3/PopupBase.qml	2017-03-13 10:06:06 +0000
@@ -57,9 +57,6 @@
                           stateWrapper.rootItem.automaticOrientation : false
     anchorToKeyboard: true
 
-    LayoutMirroring.enabled: Qt.application.layoutDirection == Qt.RightToLeft
-    LayoutMirroring.childrenInherit: true
-
     /*!
       Make the popup visible. Reparent to the background area object first if needed.
       Only use this function if you handle memory management. Otherwise use

=== modified file 'src/imports/Components/Themes/Ambiance/1.3/ButtonStyle.qml'
--- src/imports/Components/Themes/Ambiance/1.3/ButtonStyle.qml	2016-02-03 00:17:56 +0000
+++ src/imports/Components/Themes/Ambiance/1.3/ButtonStyle.qml	2017-03-13 10:06:06 +0000
@@ -44,9 +44,6 @@
     implicitWidth: Math.max(minimumWidth, foreground.implicitWidth + 2*horizontalPadding)
     implicitHeight: units.gu(4)
 
-    LayoutMirroring.enabled: Qt.application.layoutDirection == Qt.RightToLeft
-    LayoutMirroring.childrenInherit: true
-
     /*! \internal */
     // Color properties in a JS ternary operator don't work as expected in
     // QML because it overwrites alpha values with 1. A workaround is to use

=== modified file 'src/imports/Components/Themes/Ambiance/1.3/ComboButtonStyle.qml'
--- src/imports/Components/Themes/Ambiance/1.3/ComboButtonStyle.qml	2016-05-23 11:33:40 +0000
+++ src/imports/Components/Themes/Ambiance/1.3/ComboButtonStyle.qml	2017-03-13 10:06:06 +0000
@@ -37,9 +37,6 @@
     implicitWidth: mainButton.implicitWidth
     implicitHeight: mainButton.implicitHeight
 
-    LayoutMirroring.enabled: Qt.application.layoutDirection == Qt.RightToLeft
-    LayoutMirroring.childrenInherit: true
-
     Item {
         id: mainButton
 
@@ -71,9 +68,6 @@
         )
         implicitHeight: units.gu(4)
 
-        LayoutMirroring.enabled: Qt.application.layoutDirection == Qt.RightToLeft
-        LayoutMirroring.childrenInherit: true
-
         UbuntuShape {
             id: background
             anchors.fill: parent

=== modified file 'src/imports/Components/Themes/Ambiance/1.3/PageHeadStyle.qml'
--- src/imports/Components/Themes/Ambiance/1.3/PageHeadStyle.qml	2016-09-19 07:24:45 +0000
+++ src/imports/Components/Themes/Ambiance/1.3/PageHeadStyle.qml	2017-03-13 10:06:06 +0000
@@ -377,7 +377,6 @@
 
             Label {
                 objectName: "header_title_label"
-                LayoutMirroring.enabled: Qt.application.layoutDirection == Qt.RightToLeft
                 visible: !contentsContainer.visible && headerStyle.config.preset === ""
                 anchors {
                     left: parent.left