ubuntu-sdk-team team mailing list archive

[Christian Dywan <christian@xxxxxxxxxxxx>]

Christian Dywan has proposed merging lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/layoutMirroringInAdaptivePageLayout into lp:ubuntu-ui-toolkit/staging.

Commit message:
Make AdaptivePageLayout handle layoutDirection out of the box

Requested reviews:
  Ubuntu SDK team (ubuntu-sdk-team)

For more details, see:
https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/layoutMirroringInAdaptivePageLayout/+merge/319833
-- 
Your team Ubuntu SDK team is requested to review the proposed merge of lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/layoutMirroringInAdaptivePageLayout into lp:ubuntu-ui-toolkit/staging.

=== modified file 'examples/ubuntu-ui-toolkit-gallery/ubuntu-ui-toolkit-gallery.qml'
--- examples/ubuntu-ui-toolkit-gallery/ubuntu-ui-toolkit-gallery.qml	2017-02-27 13:52:42 +0000
+++ examples/ubuntu-ui-toolkit-gallery/ubuntu-ui-toolkit-gallery.qml	2017-03-14 15:36:30 +0000
@@ -29,9 +29,6 @@
     width: units.gu(120)
     height: units.gu(75)
 
-    LayoutMirroring.enabled: Qt.application.layoutDirection == Qt.RightToLeft
-    LayoutMirroring.childrenInherit: true
-
     AdaptivePageLayout {
         id: layout
         anchors.fill: parent

=== modified file 'src/imports/Components/1.3/AdaptivePageLayout.qml'
--- src/imports/Components/1.3/AdaptivePageLayout.qml	2016-09-22 05:02:24 +0000
+++ src/imports/Components/1.3/AdaptivePageLayout.qml	2017-03-14 15:36:30 +0000
@@ -193,6 +193,9 @@
 PageTreeNode {
     id: layout
 
+    LayoutMirroring.enabled: Qt.application.layoutDirection == Qt.RightToLeft
+    LayoutMirroring.childrenInherit: true
+
     Page {
         // AdaptivePageLayout has its own split headers, so
         //  disable the application header.