ubuntu-support-team team mailing list archive

[Dan Streetman <ddstreet@xxxxxxxxxxxxx>]

Dan Streetman has proposed merging ~ddstreet/ubuntu-support-tools/+git/ubuntu-support-tools:master into ubuntu-support-tools:master.

Requested reviews:
  Mauricio Faria de Oliveira (mfo)

For more details, see:
https://code.launchpad.net/~ddstreet/ubuntu-support-tools/+git/ubuntu-support-tools/+merge/385745
-- 
Your team Ubuntu Support Team is subscribed to branch ubuntu-support-tools:master.

diff --git a/tools/sru/sru-report.sh b/tools/sru/sru-report.sh
index 097af3a..064d20a 100755
--- a/tools/sru/sru-report.sh
+++ b/tools/sru/sru-report.sh
@@ -27,7 +27,7 @@ then
 	echo "Parameter file is not specified or does not exist."
 	exit 1
 fi
-file_salesforce="$(readlink -e ${file_salesforce})"
+file_salesforce="$(readlink -e "${file_salesforce}")"
 
 # Work dir
 
@@ -43,11 +43,11 @@ echo
 ##
 
 # Find SF case numbers by leading double zero
-cases="$(cat ${file_salesforce} | grep -o '>00[0-9]\{6\}<')"
+cases="$(cat "${file_salesforce}" | grep -o '>00[0-9]\{6\}<')"
 echo "Salesforce Cases found: $(echo $cases | wc -w) cases"
 
 # Find LP bug numbers by LP URLs
-bugs="$(cat ${file_salesforce} | grep -o '[^>]\+bugs.launchpad.net[^<]\+' | sort -u | grep -o '[0-9]\+')"
+bugs="$(cat "${file_salesforce}" | grep -o '[^>]\+bugs.launchpad.net[^<]\+' | sort -u | grep -o '[0-9]\+')"
 echo "Launchpad Bugs found: $(echo $bugs | wc -w) bugs"
 echo
 
@@ -56,7 +56,7 @@ echo
 # - sed: massage to get just SF case numbers and LP bugs numbers.
 # - awk: SF case number may have 1+ LP bugs (public/private bug url), print SF case number after its LP bug(s).
 file_bugs_cases="bugs_cases"
-cat ${file_salesforce} \
+cat "${file_salesforce}" \
   | grep -o \
       -e '>\+00[0-9]\{6\}<' \
       -e '[^>]\+bugs.launchpad.net[^<]\+' \