ubuntu-tn-webteam team mailing list archive

["Francis J. Lacoste" <francis.lacoste@xxxxxxxxxx>]

This change also broke 3 tests in the client.js Windmill suite.

(It expected responseText to be passed in) which is the proper thing to
revert to.

Now, that we have PUT support for fields, I think we can remove this
code (and make sure that the windmill/jstests suite is clean again).

** Changed in: launchpad
   Importance: Undecided => High

** Changed in: launchpad
       Status: New => Triaged

** Project changed: launchpad => launchpad-foundations

** Changed in: launchpad-foundations
     Assignee: (unassigned) => Leonard Richardson (leonardr)

-- 
Javascript web service client parses HTML representations as entries, even if they're not
https://bugs.launchpad.net/bugs/380959
You received this bug notification because you are a member of ubuntu-tn
LoCo Team, which is subscribed to Launchpad itself.

Status in Launchpad Foundations: Triaged

Bug description:
Edwin wrote a function called parse_xml_entry which tears apart a default XHTML representation of an entry and makes a Javascript object out of it, the same way that the web service client currently turns a JSON representation of an entry into a Javascript object.

The problem is that the default XHTML representation is just that--a default. It's not necessarily a <dl> tag with a bunch of <dt> tags underneath it. It could be any HTML at all. And even if it is a <dl> tag, it doesn't make sense to tear it apart. If you need an Entry object, you can just request a JSON representation. XHTML representations are intended for display as part of web pages. So parse_xml_entry shouldn't even exist. The response, or its responseText, or responseXML (I'm not sure which) should be passed directly into the callback method, which is responsible for integrating the HTML data into the web page.

But, I'm guessing Edwin didn't write this code for no reason. So I'm filing this bug so that we can work it out. We need to 1) figure out how to do what Edwin wants to do, 2) figure out whether we should be passing the callback the response object itself, response.responseText, or response.responseXML, and 3) get rid of parse_xml_entry.