ubuntu-touch-coreapps-reviewers team mailing list archive

[Nekhelesh Ramananthan <krnekhelesh@xxxxxxxxx>]

The proposal to merge lp:~nik90/ubuntu-clock-app/predefined-world-city-translation-fix into lp:ubuntu-clock-app has been updated.

Description changed to:

This MP fixes the predefined city and countries list not being translatable in the timezone selection page.

It fixes this bug by predefining the cities and countries as a list in c++ instead of xml thereby allowing gettext to mark those strings up for translation.

Note: This only allows translation of predefined cities and countries that are shown by default. On the other hand, results obtained from geonames.org will not be translated. This will be fixed in another MP as the code paths is quite different to this fix.

This MP looks really big since the XML list and plugin is no longer required the following files were removed and also the pot file update is also included in the diff.
- xmltimezonemodel.cpp
- xmltimezonemodel.h
- world-city-list.xml

For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/predefined-world-city-translation-fix/+merge/251180
-- 
Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nik90/ubuntu-clock-app/predefined-world-city-translation-fix into lp:ubuntu-clock-app.