ubuntu-touch-coreapps-reviewers team mailing list archive

[Michael Zanetti <michael.zanetti@xxxxxxxxxxxxx>]

Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/save-note-after-editing-tags into lp:reminders-app with lp:~mzanetti/reminders-app/needsContentSync as a prerequisite.

Commit message:
Save notes after editing tags via the ListItem action in NotesPage

Requested reviews:
  Ubuntu Reminders app developers (reminders-app-dev)

For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/save-note-after-editing-tags/+merge/251336
-- 
Your team Ubuntu Reminders app developers is requested to review the proposed merge of lp:~mzanetti/reminders-app/save-note-after-editing-tags into lp:reminders-app.

=== modified file 'src/app/qml/components/EditTagsDialog.qml'
--- src/app/qml/components/EditTagsDialog.qml	2014-12-14 04:07:07 +0000
+++ src/app/qml/components/EditTagsDialog.qml	2015-02-27 22:44:33 +0000
@@ -29,6 +29,8 @@
     property var note
     property int pageHeight
 
+    signal done();
+
     Tags {
         id: tags
     }
@@ -117,6 +119,9 @@
 
         text: i18n.tr("Done")
 
-        onClicked: PopupUtils.close(root)
+        onClicked: {
+            root.done();
+            PopupUtils.close(root)
+        }
     }
 }

=== modified file 'src/app/qml/ui/NotesPage.qml'
--- src/app/qml/ui/NotesPage.qml	2015-02-25 22:48:18 +0000
+++ src/app/qml/ui/NotesPage.qml	2015-02-27 22:44:33 +0000
@@ -203,8 +203,9 @@
                 pageStack.push(Qt.resolvedUrl("SetReminderPage.qml"), { note: NotesStore.note(model.guid) });
             }
             onEditTags: {
-                PopupUtils.open(Qt.resolvedUrl("../components/EditTagsDialog.qml"), root,
+                var popup = PopupUtils.open(Qt.resolvedUrl("../components/EditTagsDialog.qml"), root,
                                 { note: NotesStore.note(model.guid), pageHeight: root.height });
+                popup.done.connect(function() { NotesStore.saveNote(popup.note.guid)})
             }
         }