ubuntu-touch-coreapps-reviewers team mailing list archive

[Riccardo Padovani <riccardo@xxxxxxxxxxxxx>]

Review: Approve

> > Are you sure you want to implement that?
> 
> Quite sure :)
> 
> When you set a reminder or tag from the view-only mode, when would you save it
> if not directly when closing the view?
> 
> Without this change it's never saved right now, unless you go to edit mode and
> press the save button. That's not what we want I'd say.

This make sense

> > We still have two buttons in the edit mode, one for go discard changes to
> note
> > and one to save them.
> 
> Yeah, I'm probably gonna drop that. I received some feedback from users that
> the save button feels old-school and should be removed for auto-saving. Most
> modern apps don't use save/cancel buttons any more, including the Evernote
> website.

I totally agree on this, the only concern I have it's about the transition time: we will have the note save when you edit a tag, and the save when you exit the note. 
It's a strange mix.

Anyway, I'm going to approve this.

> >
> > If a user edit the content, then edit the tag, he can't discard changes
> > anymore...
> 
> I really don't think that's a big problem... It just doesn't happen that you
> accidentally change a lot of tags and need a "revert" button. You might change
> one by accident sometimes, but then you can just tap it again to re-select. If
> you miss that too, you also wouldn't press the cancel button and press the
> save button instead, because you're not aware of the mistake.
> 
> For accidentally deleting a lot of text in the edit view (which could happen
> indeed) we have an undo button nowadays.

Makes sense.
-- 
https://code.launchpad.net/~mzanetti/reminders-app/save-note-after-editing-tags/+merge/251336
Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app.