ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

ubuntu-touch-coreapps-reviewers team
Mailing list archive
Message #00271

Re: [Merge] lp:~ahayzen/ubuntu-weather-app/reboot-add-location into lp:ubuntu-weather-app/reboot

To: mp+251537@xxxxxxxxxxxxxxxxxx
From: Martin Borho <martin.borho@xxxxxxxxx>
Date: Tue, 03 Mar 2015 09:27:23 -0000
In-reply-to: <20150303002033.15641.25237.launchpad@ackee.canonical.com>
Reply-to: mp+251537@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

In AddPage.qml in Line 90 you forgot to remove "1==2", this will never equate. :)

LGTM, but shouldn't we add removing locations too to the MP?
-- 
https://code.launchpad.net/~ahayzen/ubuntu-weather-app/reboot-add-location/+merge/251537
Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~ahayzen/ubuntu-weather-app/reboot-add-location into lp:ubuntu-weather-app/reboot.

References

[Merge] lp:~ahayzen/ubuntu-weather-app/reboot-add-location into lp:ubuntu-weather-app/reboot
From: Andrew Hayzen, 2015-03-03