ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/document-hub2 into lp:ubuntu-docviewer-app

To: Stefano Verzegnassi <stefano92.100@xxxxxxxxx>
From: Riccardo Padovani <riccardo@xxxxxxxxxxxxx>
Date: Tue, 03 Mar 2015 16:12:48 -0000
In-reply-to: <20150226202920.13317.2824.launchpad@ackee.canonical.com>
Reply-to: mp+251166@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve code

Now code looks good to me.

There are some FIXME, but they don't cause any error, they are only minor code refactoring you can do in a second moment.

Since this branch has a lot of improvements, I think is good enough to land, I'm sure you will do other branches for little fixes :-)

As we discussed yesterday, I'm not able to launch it on vivid desktop, but could be a my problem.
Anyway, I wasn't able to review the UI/UX. Code is good, but I leave to popey the top approving :-)
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/document-hub2/+merge/251166
Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app.