← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-translation-issues into lp:ubuntu-docviewer-app

 

The proposal to merge lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-translation-issues into lp:ubuntu-docviewer-app has been updated.

Description changed to:

Fixes for several issues related with translations

* In utils.js I used a workaround that has been accepted earlier in the clock-app (i18n singleton is not available in JS file).
* Fixed plural form in DeleteFile.qml (the "path ? <true_condition> : <false_condition>" has been keeped, since the removal of files work differently if called from selection mode instead of the ListItem swipe gesture)
* In DocumentGridDelegate.qml arguments are used in order to avoid truncation of translatable strings
* Fix for ErrorDialog not working (Ubuntu.Components.Popups import missing)

For more details, see:
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/fix-translation-issues/+merge/251788
-- 
Your team Ubuntu Document Viewer Developers is requested to review the proposed merge of lp:~verzegnassi-stefano/ubuntu-docviewer-app/fix-translation-issues into lp:ubuntu-docviewer-app.


References