ubuntu-touch-coreapps-reviewers team mailing list archive

[Michael Zanetti <michael.zanetti@xxxxxxxxxxxxx>]

Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/fix-tags-crash into lp:reminders-app.

Commit message:
properly parent tags to prevent qml from deleting them

Requested reviews:
  Ubuntu Reminders app developers (reminders-app-dev)
Related bugs:
  Bug #1427830 in Ubuntu Reminders app: "TAGS: Adding a first tag and removing it crashes the app"
  https://bugs.launchpad.net/reminders-app/+bug/1427830

For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/fix-tags-crash/+merge/251812
-- 
Your team Ubuntu Reminders app developers is requested to review the proposed merge of lp:~mzanetti/reminders-app/fix-tags-crash into lp:reminders-app.

=== modified file 'src/libqtevernote/notesstore.cpp'
--- src/libqtevernote/notesstore.cpp	2015-03-04 00:23:45 +0000
+++ src/libqtevernote/notesstore.cpp	2015-03-04 19:19:58 +0000
@@ -469,7 +469,7 @@
 
 Tag* NotesStore::createTag(const QString &name)
 {
-    Tag *tag = new Tag(QUuid::createUuid().toString().remove(QRegExp("[\{\}]*")), 1);
+    Tag *tag = new Tag(QUuid::createUuid().toString().remove(QRegExp("[\{\}]*")), 1, this);
     tag->setName(name);
     m_tags.append(tag);
     m_tagsHash.insert(tag->guid(), tag);