ubuntu-touch-coreapps-reviewers team mailing list archive

[Michael Zanetti <michael.zanetti@xxxxxxxxxxxxx>]

Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/fix-sort-init into lp:reminders-app.

Commit message:
fix initialisation of sortOrder properties

Requested reviews:
  Ubuntu Reminders app developers (reminders-app-dev)

For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/fix-sort-init/+merge/251850

If setting sort order to "created, newest first" the sort order will be wrong at startup because the model's property is set to CreatedNewestFirst while the ctor actually sorts for "updated, newest first".
-- 
Your team Ubuntu Reminders app developers is requested to review the proposed merge of lp:~mzanetti/reminders-app/fix-sort-init into lp:reminders-app.

=== modified file 'src/libqtevernote/notes.cpp'
--- src/libqtevernote/notes.cpp	2015-02-25 22:45:58 +0000
+++ src/libqtevernote/notes.cpp	2015-03-04 23:53:24 +0000
@@ -28,7 +28,7 @@
     m_onlyReminders(false),
     m_onlySearchResults(false),
     m_showDeleted(false),
-    m_sortOrder(SortOrderDateCreatedNewest)
+    m_sortOrder(SortOrderDateUpdatedNewest)
 {
     connect(NotesStore::instance(), &NotesStore::loadingChanged, this, &Notes::loadingChanged);
     connect(NotesStore::instance(), &NotesStore::errorChanged, this, &Notes::errorChanged);