← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~mzanetti/reminders-app/disable-push-notifications into lp:reminders-app

 

Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/disable-push-notifications into lp:reminders-app.

Commit message:
disable push notifications for now

We haven't had a chance to properly test and don't want users to run into issues when it gets enabled on the server side.

Requested reviews:
  Ubuntu Reminders app developers (reminders-app-dev)

For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/disable-push-notifications/+merge/251985
-- 
Your team Ubuntu Reminders app developers is requested to review the proposed merge of lp:~mzanetti/reminders-app/disable-push-notifications into lp:reminders-app.
=== modified file 'src/app/qml/reminders.qml'
--- src/app/qml/reminders.qml	2015-03-04 14:31:29 +0000
+++ src/app/qml/reminders.qml	2015-03-05 17:04:09 +0000
@@ -394,7 +394,8 @@
         target: UserStore
         onUsernameChanged: {
             print("Logged in as user:", UserStore.username);
-            registerPushClient();
+            // Disabling push notifications as we haven't had a chance to properly test that yet
+            //registerPushClient();
         }
     }
 


Follow ups