ubuntu-touch-coreapps-reviewers team mailing list archive

[Andrew Hayzen <ahayzen@xxxxxxxxx>]

Andrew Hayzen has proposed merging lp:~ahayzen/music-app/refactor-fix-1428450-delete-playlist-freeze into lp:music-app/refactor.

Commit message:
* Destroy dialog before popping page

Requested reviews:
  Music App Developers (music-app-dev)
Related bugs:
  Bug #1428450 in Ubuntu Music App: "[refactor] Deleting a playlist causes the application to freeze"
  https://bugs.launchpad.net/music-app/+bug/1428450

For more details, see:
https://code.launchpad.net/~ahayzen/music-app/refactor-fix-1428450-delete-playlist-freeze/+merge/252051

* Destroy dialog before popping page
-- 
Your team Music App Developers is requested to review the proposed merge of lp:~ahayzen/music-app/refactor-fix-1428450-delete-playlist-freeze into lp:music-app/refactor.

=== modified file 'app/components/Dialog/RemovePlaylistDialog.qml'
--- app/components/Dialog/RemovePlaylistDialog.qml	2015-02-04 20:35:53 +0000
+++ app/components/Dialog/RemovePlaylistDialog.qml	2015-03-06 01:09:02 +0000
@@ -48,6 +48,9 @@
             songStackPage.page = undefined
             PopupUtils.close(dialogRemovePlaylist)
 
+            // need to destroy the dialog before popping fixes pad.lv/1428450
+            dialogRemovePlaylist.destroy()
+
             mainPageStack.goBack()
         }
     }