← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~nik90/ubuntu-weather-app/1-improve-add-location-page into lp:ubuntu-weather-app/reboot

 

The proposal to merge lp:~nik90/ubuntu-weather-app/1-improve-add-location-page into lp:ubuntu-weather-app/reboot has been updated.

Commit Message changed to:

This MP brings the Add Location Page more in line with Clock app's own add city page to maintain consistency. Also there was no design specified for the add location page in weather app's design spec.

- Added fast scroll to add location page
- Renamed AddPage.qml to AddLocationPage.qml to be more specific
- Added section headers to listview
- Removed focus on search textfield immediately after opening the add location page. The reasoning here being that we show a list of cities that the user can choose from. Only if doesnt find his city there should he resort to searching online.
- Moved the search textfield to a component to allow for dynamic loading

For more details, see:
https://code.launchpad.net/~nik90/ubuntu-weather-app/1-improve-add-location-page/+merge/252115
-- 
Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~nik90/ubuntu-weather-app/1-improve-add-location-page into lp:ubuntu-weather-app/reboot.


References