ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~ahayzen/music-app/refactor-split-content-hub-url-handler-metrics into lp:music-app/refactor

To: mp+249887@xxxxxxxxxxxxxxxxxx
From: Victor Thompson <victor.thompson@xxxxxxxxx>
Date: Mon, 09 Mar 2015 00:10:35 -0000
In-reply-to: <20150216210034.3991.95420.launchpad@ackee.canonical.com>
Reply-to: mp+249887@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information

This looks good and I haven't found any issues. I think it might be best to rename MetricHelper as UserMetricsHelper. Even though the component is called "Metric" I think naming the helper so it matches the library being used makes things more clear. The other helpers have names that describe their content quite clearly.
-- 
https://code.launchpad.net/~ahayzen/music-app/refactor-split-content-hub-url-handler-metrics/+merge/249887
Your team Music App Developers is subscribed to branch lp:music-app/refactor.