ubuntu-touch-coreapps-reviewers team mailing list archive
-
ubuntu-touch-coreapps-reviewers team
-
Mailing list archive
-
Message #00625
[Merge] lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot
Riccardo Padovani has proposed merging lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot.
Commit message:
Added .svg files to CMake. Fixes bug #1428607.
Requested reviews:
Ubuntu Calculator Developers (ubuntu-calculator-dev)
For more details, see:
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/fixBlankIcons/+merge/252544
Added .svg files to CMake. Fixes bug #1428607.
## NOT TESTED YET
I'm on a machine without chroot. Need to create a .click package and see if it works as expected (e.g. fixes #1428607).
--
Your team Ubuntu Calculator Developers is requested to review the proposed merge of lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot.
=== modified file 'app/CMakeLists.txt'
--- app/CMakeLists.txt 2014-12-28 14:20:45 +0000
+++ app/CMakeLists.txt 2015-03-11 09:18:26 +0000
@@ -11,6 +11,7 @@
install(FILES ${MAIN_QML} DESTINATION ${UBUNTU-CALCULATOR-APP_DIR})
add_subdirectory(engine)
+add_subdirectory(graphics)
add_subdirectory(ui)
add_subdirectory(upstreamcomponents)
add_subdirectory(tests)
=== added file 'app/graphics/CMakeLists.txt'
--- app/graphics/CMakeLists.txt 1970-01-01 00:00:00 +0000
+++ app/graphics/CMakeLists.txt 2015-03-11 09:18:26 +0000
@@ -0,0 +1,4 @@
+file(GLOB GRAPHICS_FILES *.svg)
+
+install(FILES ${GRAPHICS_FILES} DESTINATION ${UBUNTU-CALCULATOR-APP_DIR}/graphics)
+
Follow ups
-
[Merge] lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot
From: noreply, 2015-03-25
-
Re: [Merge] lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot
From: Ubuntu Phone Apps Jenkins Bot, 2015-03-25
-
[Merge] lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot
From: Bartosz Kosiorek, 2015-03-25
-
[Merge] lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot
From: Ubuntu Phone Apps Jenkins Bot, 2015-03-24
-
Re: [Merge] lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot
From: Ubuntu Phone Apps Jenkins Bot, 2015-03-24
-
[Merge] lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot
From: Alan Pope , 2015-03-24
-
[Merge] lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot
From: Ubuntu Phone Apps Jenkins Bot, 2015-03-24
-
Re: [Merge] lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot
From: Ubuntu Phone Apps Jenkins Bot, 2015-03-24
-
[Merge] lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot
From: Alan Pope , 2015-03-24
-
Re: [Merge] lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot
From: Ubuntu Phone Apps Jenkins Bot, 2015-03-23
-
[Merge] lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot
From: Ubuntu Phone Apps Jenkins Bot, 2015-03-23
-
[Merge] lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot
From: Bartosz Kosiorek, 2015-03-23
-
Re: [Merge] lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot
From: Bartosz Kosiorek, 2015-03-23
-
[Merge] lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot
From: Riccardo Padovani, 2015-03-23
-
Re: [Merge] lp:~rpadovani/ubuntu-calculator-app/fixBlankIcons into lp:ubuntu-calculator-app/reboot
From: Ubuntu Phone Apps Jenkins Bot, 2015-03-11