ubuntu-touch-coreapps-reviewers team mailing list archive

[Riccardo Padovani <riccardo@xxxxxxxxxxxxx>]

Riccardo Padovani has proposed merging lp:~rpadovani/reminders-app/hideTagsBarWithNoTag into lp:reminders-app.

Commit message:
Do not show the tags bar in the note view if there are no tags

Requested reviews:
  Ubuntu Reminders app developers (reminders-app-dev)
Related bugs:
  Bug #1430160 in Ubuntu Reminders app: "Do not show the tags bar if there are no tags"
  https://bugs.launchpad.net/reminders-app/+bug/1430160

For more details, see:
https://code.launchpad.net/~rpadovani/reminders-app/hideTagsBarWithNoTag/+merge/252552

Fix #1430160
-- 
Your team Ubuntu Reminders app developers is requested to review the proposed merge of lp:~rpadovani/reminders-app/hideTagsBarWithNoTag into lp:reminders-app.

=== modified file 'src/app/qml/ui/NoteView.qml'
--- src/app/qml/ui/NoteView.qml	2015-02-23 17:57:05 +0000
+++ src/app/qml/ui/NoteView.qml	2015-03-11 10:44:40 +0000
@@ -110,7 +110,8 @@
         model: root.note ? root.note.tagGuids.length : undefined
         orientation: ListView.Horizontal
         spacing: units.gu(1)
-        height: units.gu(3)
+        height: visible ? units.gu(3) : 0
+        visible: root.note ? root.note.tagGuids.length > 0 ? true : false : false
 
         delegate: Rectangle {
             id: rectangle