ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/ubuntu-weather-app/reboot-pull-refresh into lp:ubuntu-weather-app/reboot.

Commit message:
* Add pull to refresh support

Requested reviews:
  Ubuntu Weather Developers (ubuntu-weather-dev)

For more details, see:
https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-pull-refresh/+merge/252832

This is a simple change to get "Pull to refresh" working. Currently, the consensus is that we will add an icon to trigger a refresh of the data--however, I wanted to see what other people thought of this approach.
-- 
Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~vthompson/ubuntu-weather-app/reboot-pull-refresh into lp:ubuntu-weather-app/reboot.

=== modified file 'app/ui/HomePage.qml'
--- app/ui/HomePage.qml	2015-03-03 18:37:59 +0000
+++ app/ui/HomePage.qml	2015-03-12 22:21:28 +0000
@@ -87,6 +87,13 @@
         height: parent.height
         contentWidth: parent.width
 
+        PullToRefresh {
+            id: pullToRefresh
+            parent: locationFlickable
+            refreshing: locationPages.loaded === false
+            onRefresh: refreshData(false, true)
+        }
+
         /*
           ListView for locations with snap-scrolling horizontally.
         */