ubuntu-touch-coreapps-reviewers team mailing list archive

[Michael Zanetti <michael.zanetti@xxxxxxxxxxxxx>]

Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/underline-highlight into lp:reminders-app.

Commit message:
fix underline button state not always updating

Requested reviews:
  Ubuntu Reminders app developers (reminders-app-dev)

For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/underline-highlight/+merge/253284
-- 
Your team Ubuntu Reminders app developers is requested to review the proposed merge of lp:~mzanetti/reminders-app/underline-highlight into lp:reminders-app.

=== modified file 'src/app/formattinghelper.cpp'
--- src/app/formattinghelper.cpp	2015-03-06 00:47:45 +0000
+++ src/app/formattinghelper.cpp	2015-03-17 21:59:03 +0000
@@ -224,12 +224,12 @@
     if (m_selectionCursor.selectedText().isEmpty()) {
         m_nextFormat.setFontUnderline(underline);
         m_formatPosition = m_textCursor.position();
-        emit formatChanged();
     } else {
         QTextCharFormat f = m_selectionCursor.charFormat();
         f.setFontUnderline(underline);
         m_selectionCursor.setCharFormat(f);
     }
+    emit formatChanged();
 }
 
 bool FormattingHelper::strikeout() const