← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~dholbach/help-app/1435783 into lp:help-app

 

Daniel Holbach has proposed merging lp:~dholbach/help-app/1435783 into lp:help-app.

Commit message:
Fixes a path, so that translated markdown is written into the correct directory.

Test case in the description of https://bugs.launchpad.net/help-app/+bug/1435783

Requested reviews:
  Ubuntu Help app developers (help-app-dev)
Related bugs:
  Bug #1435783 in Ubuntu Help App: "Path transition not complete"
  https://bugs.launchpad.net/help-app/+bug/1435783

For more details, see:
https://code.launchpad.net/~dholbach/help-app/1435783/+merge/253952
-- 
Your team Ubuntu Help app developers is requested to review the proposed merge of lp:~dholbach/help-app/1435783 into lp:help-app.
=== modified file 'internals/translations/build.py'
--- internals/translations/build.py	2015-03-20 10:31:12 +0000
+++ internals/translations/build.py	2015-03-24 11:00:30 +0000
@@ -275,8 +275,8 @@
 
                 # Remove the metadata line
                 content = '\n'.join([line for line in output.split('\n')][1:])
-                new_path = self.translated_doc_fn(doc_fn,
-                                                  po.langs[po_fn]['bcp47'])
+                new_path = full_path(
+                    self.translated_doc_fn(doc_fn, po.langs[po_fn]['bcp47']))
 
                 # Flatten the metadata dict into a string
                 metadata_serialized = '\n'.join(


References