ubuntu-touch-coreapps-reviewers team mailing list archive

[Roman Shchekin <mrqtros@xxxxxxxxx>]

Roman Shchekin has proposed merging lp:~mrqtros/ubuntu-rssreader-app/ubuntu-rssreader-app-choose-topic-bug into lp:ubuntu-rssreader-app.

Commit message:
Skip empty URLs in results

Requested reviews:
  Ubuntu RSS Feed Reader Developers (ubuntu-rssreader-dev)

For more details, see:
https://code.launchpad.net/~mrqtros/ubuntu-rssreader-app/ubuntu-rssreader-app-choose-topic-bug/+merge/254040

Search page now skips results with empty URLs (which causes bugs)

-- 
Your team Ubuntu RSS Feed Reader Developers is requested to review the proposed merge of lp:~mrqtros/ubuntu-rssreader-app/ubuntu-rssreader-app-choose-topic-bug into lp:ubuntu-rssreader-app.

=== modified file 'feeds/AppendFeedPage.qml'
--- feeds/AppendFeedPage.qml	2014-12-21 20:56:23 +0000
+++ feeds/AppendFeedPage.qml	2015-03-25 07:33:24 +0000
@@ -77,6 +77,10 @@
             var entries = result.responseData.entries
 
             for (var i = 0; i < entries.length; i++) {
+                // Skip entries with empty URL.
+                if (!entries[i].url)
+                    continue
+
                 searchResultsModel.append({"url" : entries[i].url,
                                               "title" : entries[i].title,
                                               "description" : entries[i].contentSnippet,