ubuntu-touch-coreapps-reviewers team mailing list archive

[Daniel Holbach <daniel.holbach@xxxxxxxxxx>]

Daniel Holbach has proposed merging lp:~dholbach/help-app/run-pep8-and-pyflakes3 into lp:help-app.

Commit message:
Run pyflakes3 and pep8 as part of the 'check' target.

Requested reviews:
  Ubuntu Help app developers (help-app-dev)

For more details, see:
https://code.launchpad.net/~dholbach/help-app/run-pep8-and-pyflakes3/+merge/254059
-- 
Your team Ubuntu Help app developers is requested to review the proposed merge of lp:~dholbach/help-app/run-pep8-and-pyflakes3 into lp:help-app.

=== modified file 'HACKING'
--- HACKING	2015-03-20 14:18:33 +0000
+++ HACKING	2015-03-25 10:14:58 +0000
@@ -86,7 +86,7 @@
 
   sudo apt install python-pelican po4a make bzrtools \
 	ubuntu-html5-ui-toolkit python3-polib python3-magic \
-	python3-markdown
+	python3-markdown pep8 pyflakes
 
 This will install the necessary files, so you can build the app or web build
 locally and check if your changes actually make sense and look and work well.

=== modified file 'Makefile'
--- Makefile	2015-03-20 12:25:41 +0000
+++ Makefile	2015-03-25 10:14:58 +0000
@@ -54,6 +54,7 @@
 
 check:
 	cd $(INTERNALS_DIR); ./run-tests
+	cd $(INTERNALS_DIR); ./run-other-tests
 
 translations:
 	cd $(INTERNALS_DIR); ./generate-translations

=== modified file 'debian/control'
--- debian/control	2015-03-11 11:57:50 +0000
+++ debian/control	2015-03-25 10:14:58 +0000
@@ -4,7 +4,9 @@
 Maintainer: Daniel Holbach <daniel.holbach@xxxxxxxxxx>
 Build-Depends: bzr,
                debhelper (>= 9),
+               pep8,
                po4a,
+               pyflakes,
                python-pelican (>= 3.5.0~),
                python3-magic,
                python3-markdown,

=== added file 'internals/run-other-tests'
--- internals/run-other-tests	1970-01-01 00:00:00 +0000
+++ internals/run-other-tests	2015-03-25 10:14:58 +0000
@@ -0,0 +1,4 @@
+#!/bin/sh -e
+
+pep8 --repeat --show-source .
+pyflakes3 .