← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

Re: [Merge] lp:~dholbach/help-app/1434210 into lp:help-app

 

Review: Needs Fixing

Works well, but I've noticed a couple of things that might need fixing while we're at it:

- Running 'make html' and then 'make web' deletes the ./build/app directory. I'd expect the web build not to affect the app build, which would only be deleted after a 'make clean'
- It might be worth renaming 'make html' to 'make app' for consistency with the changes in the tree.
-- 
https://code.launchpad.net/~dholbach/help-app/1434210/+merge/254706
Your team Ubuntu Help app developers is subscribed to branch lp:help-app.


References