ubuntu-touch-coreapps-reviewers team mailing list archive

[Riccardo Padovani <riccardo@xxxxxxxxxxxxx>]

Riccardo Padovani has proposed merging lp:~rpadovani/ubuntu-calculator-app/waitUntilOskIsHidden into lp:ubuntu-calculator-app/reboot.

Commit message:
Wait until osk keyboard is hidden before showing our custom keyboard

Requested reviews:
  Ubuntu Calculator Developers (ubuntu-calculator-dev)
Related bugs:
  Bug #1438295 in Ubuntu Calculator App: "[reboot] Saving favourites causes screen to leap around erratically"
  https://bugs.launchpad.net/ubuntu-calculator-app/+bug/1438295

For more details, see:
https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/waitUntilOskIsHidden/+merge/254875

Wait until osk keyboard is hidden before showing our custom keyboard
-- 
Your team Ubuntu Calculator Developers is requested to review the proposed merge of lp:~rpadovani/ubuntu-calculator-app/waitUntilOskIsHidden into lp:ubuntu-calculator-app/reboot.

=== modified file 'app/ubuntu-calculator-app.qml'
--- app/ubuntu-calculator-app.qml	2015-03-30 08:33:45 +0000
+++ app/ubuntu-calculator-app.qml	2015-04-01 08:42:21 +0000
@@ -635,7 +635,7 @@
                 Loader {
                     id: keyboardLoader
                     width: parent.width
-                    visible: textInputField.visible && !oskKeyboard.visible
+                    visible: textInputField.visible && (!oskKeyboard.height || oskKeyboard.height === 0)
                     source: scrollableView.width > scrollableView.height ? "ui/LandscapeKeyboard.qml" : "ui/PortraitKeyboard.qml"
                     opacity: ((y + height) >= scrollableView.contentY) && (y <= (scrollableView.contentY + scrollableView.height)) ? 1 : 0
                 }