ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~ahayzen/music-app/refactor-delay-urlhandler-contenthub-after-walkthrough into lp:music-app/refactor

To: mp+254760@xxxxxxxxxxxxxxxxxx
From: Victor Thompson <victor.thompson@xxxxxxxxx>
Date: Sat, 04 Apr 2015 19:59:23 -0000
In-reply-to: <20150331134921.17397.43475.launchpad@ackee.canonical.com>
Reply-to: mp+254760@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information

It seems a little odd to have a helper component just to store a function to be called later--but I'm OK with it. Would it make more sense to use a JS library or something? 

import "external-request.js" as ExternalRequest 

I'll try to do some testing a bit later on.
-- 
https://code.launchpad.net/~ahayzen/music-app/refactor-delay-urlhandler-contenthub-after-walkthrough/+merge/254760
Your team Music App Developers is subscribed to branch lp:music-app/refactor.

References

[Merge] lp:~ahayzen/music-app/refactor-delay-urlhandler-contenthub-after-walkthrough into lp:music-app/refactor
From: Andrew Hayzen, 2015-03-31