ubuntu-touch-coreapps-reviewers team mailing list archive

[Victor Thompson <victor.thompson@xxxxxxxxx>]

Victor Thompson has proposed merging lp:~vthompson/music-app/test_pressing_prev_after_5_seconds into lp:music-app.

Commit message:
Don't wait < 5s in test_pressing_prev_after_5_seconds

Requested reviews:
  Music App Developers (music-app-dev)
Related bugs:
  Bug #1442927 in Ubuntu Music App: "[music] test_pressing_prev_after_5_seconds occasionally fails in the CI Dash tests for vivid"
  https://bugs.launchpad.net/music-app/+bug/1442927

For more details, see:
https://code.launchpad.net/~vthompson/music-app/test_pressing_prev_after_5_seconds/+merge/255908

Don't wait < 5s in test_pressing_prev_after_5_seconds. See bug report for description of the issue.
-- 
Your team Music App Developers is requested to review the proposed merge of lp:~vthompson/music-app/test_pressing_prev_after_5_seconds into lp:music-app.

=== modified file 'tests/autopilot/music_app/tests/test_music.py'
--- tests/autopilot/music_app/tests/test_music.py	2015-03-21 14:00:22 +0000
+++ tests/autopilot/music_app/tests/test_music.py	2015-04-11 16:46:56 +0000
@@ -701,7 +701,5 @@
 
         now_playing_page.click_previous_button()  # click previous
 
-        self.player.position.wait_for(LessThan(5000))  # wait until < 5s
-
         # Check that the source is the same
         self.assertThat(self.player.source, Eventually(Equals(source)))