ubuntu-touch-coreapps-reviewers team mailing list archive

[Kunal Parmar <pkunal.parmar@xxxxxxxxx>]

Review: Needs Fixing

I added comment inline, anyway I am proposing another MR for this fix.

Diff comments:

> === modified file 'EventRepetition.qml'
> --- EventRepetition.qml	2014-10-22 14:03:01 +0000
> +++ EventRepetition.qml	2015-04-03 16:45:43 +0000
> @@ -100,8 +100,23 @@
>              var recurrenceRule = Defines.recurrenceValue[ recurrenceOption.selectedIndex ];
>              if (recurrenceRule !== RecurrenceRule.Invalid) {
>                  rule.frequency = recurrenceRule;
> +                if( recurrenceOption.selectedIndex < 5 ){
> +                    //If it is daily or weekly or alternate days
> +                    rule.daysOfWeek = eventUtils.getDaysOfWeek(recurrenceOption.selectedIndex,weekDays );
> +                } else {
> +                    //Monthly or Yearly
> +                    switch(recurrenceOption.selectedIndex){
> +                        case 6:
> +                            //Monthly
> +                            rule.daysOfMonth = [date.getMonth()];

daysofMonth means which date of month this event should recur, but you are inputting Month there

> +                            break;
> +                        case 7:
> +                            //Yearly
> +                            rule.daysOfYear = [date.getYear];

Same as above, and how you are inputting for which month this event should recur ?

> +                    }
> +
> +                }
>                  if (recurrenceOption.selectedIndex > 0) {
> -                    rule.daysOfWeek = eventUtils.getDaysOfWeek(recurrenceOption.selectedIndex,weekDays );
>                      if (limitOptions.selectedIndex === 1
>                              && recurrenceOption.selectedIndex > 0
>                              && limitCount.text != "") {
> @@ -143,7 +158,7 @@
>              }
>  
>              model: Defines.recurrenceLabel
> -            containerHeight: itemHeight * 4
> +            containerHeight: itemHeight * 9
>              onExpandedChanged: Qt.inputMethod.hide();
>          }
>  
> 


-- 
https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/1438910/+merge/255123
Your team Ubuntu Calendar Developers is subscribed to branch lp:ubuntu-calendar-app.