← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~nik90/ubuntu-clock-app/fix-location-error-msg into lp:ubuntu-clock-app

 

The proposal to merge lp:~nik90/ubuntu-clock-app/fix-location-error-msg into lp:ubuntu-clock-app has been updated.

Description changed to:

This MP removes the "Location service error" message which is shown when the user denies clock app location access and also when the location service does not work when opening the clock app for the *first* time.

Steps to test
-------------

1. Start with a clean slate by removing .local/share/com.ubuntu.clock/user-preferences

2. Disable clock app location access in system-settings-app->Security&Privacy->Location acess->Clock

3. Open the clock app

4. The location label shouldn't be shown. The date label should now be shown more prominently.

5. Close the clock app

6. Enable clock app location access similar to step 2.

7. Reopen the clock app

8. The location label shows "Retrieving location" and then shortly after shows your location

9. Close and reopen clock app. It should still show your location.

10. At this point even if you disable clock app location access and reopen the clock app, it should still show the cached location.

For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-location-error-msg/+merge/256230
-- 
Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nik90/ubuntu-clock-app/fix-location-error-msg into lp:ubuntu-clock-app.


References