ubuntu-touch-coreapps-reviewers team mailing list archive
-
ubuntu-touch-coreapps-reviewers team
-
Mailing list archive
-
Message #01692
[Merge] lp:~vthompson/ubuntu-weather-app/reboot-white-bg into lp:ubuntu-weather-app/reboot
Victor Thompson has proposed merging lp:~vthompson/ubuntu-weather-app/reboot-white-bg into lp:ubuntu-weather-app/reboot.
Commit message:
* Add a white background to the PageWithBottomEdge
Requested reviews:
Ubuntu Weather Developers (ubuntu-weather-dev)
For more details, see:
https://code.launchpad.net/~vthompson/ubuntu-weather-app/reboot-white-bg/+merge/256762
* Add a white background to the PageWithBottomEdge
This was done outside of the PageWithBottomEdge component to make it easier to sync changes from upstream.
--
Your team Ubuntu Weather Developers is requested to review the proposed merge of lp:~vthompson/ubuntu-weather-app/reboot-white-bg into lp:ubuntu-weather-app/reboot.
=== modified file 'app/ui/HomePage.qml'
--- app/ui/HomePage.qml 2015-03-18 00:05:43 +0000
+++ app/ui/HomePage.qml 2015-04-19 21:12:57 +0000
@@ -78,6 +78,15 @@
}
/*
+ Background for the PageWithBottomEdge
+ */
+ Rectangle {
+ id: pageBackground
+ anchors.fill: parent
+ color: "white"
+ }
+
+ /*
Flickable to scroll the location vertically.
The respective contentHeight gets calculated after the Location is filled with data.
*/
=== modified file 'po/com.ubuntu.weather.pot'
--- po/com.ubuntu.weather.pot 2015-04-11 00:27:59 +0000
+++ po/com.ubuntu.weather.pot 2015-04-19 21:12:57 +0000
@@ -8,7 +8,7 @@
msgstr ""
"Project-Id-Version: ubuntu-weather-app\n"
"Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2015-04-11 02:27+0200\n"
+"POT-Creation-Date: 2015-04-19 16:08-0500\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@xxxxxx>\n"
Follow ups