← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~mzanetti/reminders-app/that-darn-focus into lp:reminders-app

 

Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/that-darn-focus into lp:reminders-app.

Commit message:
Take the focus on closing for real

Requested reviews:
  Ubuntu Reminders app developers (reminders-app-dev)

For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/that-darn-focus/+merge/257554
-- 
Your team Ubuntu Reminders app developers is requested to review the proposed merge of lp:~mzanetti/reminders-app/that-darn-focus into lp:reminders-app.
=== modified file 'src/app/qml/components/RtfButton.qml'
--- src/app/qml/components/RtfButton.qml	2015-04-09 17:49:40 +0000
+++ src/app/qml/components/RtfButton.qml	2015-04-27 17:29:27 +0000
@@ -29,6 +29,7 @@
     property string color: "transparent"
     property alias iconColor: icon.color
     property alias horizontalAlignment: textField.horizontalAlignment
+    property alias activeFocusOnPress: mouseArea.activeFocusOnPress
 
     property alias font: textField.font
 

=== modified file 'src/app/qml/ui/EditNoteView.qml'
--- src/app/qml/ui/EditNoteView.qml	2015-04-09 17:49:40 +0000
+++ src/app/qml/ui/EditNoteView.qml	2015-04-27 17:29:27 +0000
@@ -628,8 +628,8 @@
                 text: i18n.tr("Done")
                 height: parent.height
                 iconColor: UbuntuColors.green
+                activeFocusOnPress: true
                 onClicked: {
-                    noteTextArea.focus = false;
                     saveNote();
                     root.exitEditMode(root.note);
                 }


Follow ups