ubuntu-touch-coreapps-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-07 into lp:ubuntu-filemanager-app

To: Carlos Jose Mazieri <carlos.mazieri@xxxxxxxxx>
From: Arto Jalkanen <ajalkane@xxxxxxxxx>
Date: Mon, 27 Apr 2015 20:08:32 -0000
In-reply-to: <20150314182321.18477.61380.launchpad@ackee.canonical.com>
Reply-to: mp+252976@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Instead of using "static    QByteArray  m_AuthUser[MAX_AUTH_INSTANCES];" modern C++ prefers using unnamed namespaces, for example:

namespace {
  QByteArray  m_AuthUser[MAX_AUTH_INSTANCES];
  QByteArray  m_AuthPass[MAX_AUTH_INSTANCES];
  void *      m_instances[MAX_AUTH_INSTANCES];
}

-- 
https://code.launchpad.net/~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-07/+merge/252976
Your team Ubuntu File Manager Developers is subscribed to branch lp:ubuntu-filemanager-app.

References

[Merge] lp:~carlos-mazieri/ubuntu-filemanager-app/samba-browsing-07 into lp:ubuntu-filemanager-app
From: Carlos Jose Mazieri, 2015-03-14