ubuntu-touch-coreapps-reviewers team mailing list archive

[Kunal Parmar <pkunal.parmar@xxxxxxxxx>]

Kunal Parmar has proposed merging lp:~pkunal-parmar/ubuntu-calendar-app/DefReminderTime into lp:ubuntu-calendar-app.

Commit message:
Resolves Bug #1419001

Setting default reminder time to 15 min

Requested reviews:
  Ubuntu Calendar Developers (ubuntu-calendar-dev)
Related bugs:
  Bug #1419001 in Ubuntu Calendar App: "Reminders trigger at the time of the event and not before by default"
  https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1419001

For more details, see:
https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/DefReminderTime/+merge/257743

Resolves Bug #1419001

Setting default reminder time to 15 min
-- 
Your team Ubuntu Calendar Developers is requested to review the proposed merge of lp:~pkunal-parmar/ubuntu-calendar-app/DefReminderTime into lp:ubuntu-calendar-app.

=== modified file 'NewEvent.qml'
--- NewEvent.qml	2015-04-05 04:54:54 +0000
+++ NewEvent.qml	2015-04-29 12:23:41 +0000
@@ -224,10 +224,14 @@
     }
 
     VisualReminder{
-        id:visualReminder
+        id: visualReminder
+        //default reminder time = 15 min
+        secondsBeforeStart: 900
     }
     AudibleReminder{
-        id:audibleReminder
+        id: audibleReminder
+        //default reminder time = 15 min
+        secondsBeforeStart: 900
     }
 
     function getDaysOfWeek(){
@@ -590,9 +594,7 @@
                 id:eventReminder
                 objectName  : "eventReminder"
 
-                anchors{
-                    left:parent.left
-                }
+                anchors.left:parent.left
                 showDivider: false
                 progression: true
                 text: i18n.tr("Reminder")
@@ -603,12 +605,11 @@
 
                 subText:{
                     if(visualReminder.secondsBeforeStart !== -1) {
-                        for(var i=0; i<reminderModel.count; i++) {
-                            if(visualReminder.secondsBeforeStart === reminderModel.get(i).value)
+                        for( var i=0; i<reminderModel.count; i++ ) {
+                            if(visualReminder.secondsBeforeStart === reminderModel.get(i).value) {
                                 return reminderModel.get(i).label
+                            }
                         }
-                    } else {
-                        reminderModel.get(0).label
                     }
                 }