← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~mzanetti/reminders-app/still-that-focus into lp:reminders-app

 

Michael Zanetti has proposed merging lp:~mzanetti/reminders-app/still-that-focus into lp:reminders-app with lp:~mzanetti/reminders-app/fix-renderwidth as a prerequisite.

Requested reviews:
  Ubuntu Reminders app developers (reminders-app-dev)
Related bugs:
  Bug #1452907 in Ubuntu Reminders app: "In edit note "Done" button required twice to save when OSK out"
  https://bugs.launchpad.net/reminders-app/+bug/1452907

For more details, see:
https://code.launchpad.net/~mzanetti/reminders-app/still-that-focus/+merge/258566
-- 
Your team Ubuntu Reminders app developers is requested to review the proposed merge of lp:~mzanetti/reminders-app/still-that-focus into lp:reminders-app.
=== modified file 'src/app/qml/ui/EditNoteView.qml'
--- src/app/qml/ui/EditNoteView.qml	2015-05-07 21:46:21 +0000
+++ src/app/qml/ui/EditNoteView.qml	2015-05-07 21:46:21 +0000
@@ -629,8 +629,8 @@
                 text: i18n.tr("Done")
                 height: parent.height
                 iconColor: UbuntuColors.green
-                activeFocusOnPress: true
                 onClicked: {
+                    forceActiveFocus();
                     saveNote();
                     root.exitEditMode(root.note);
                 }


Follow ups