ubuntu-touch-coreapps-reviewers team mailing list archive

[Daniel Holbach <daniel.holbach@xxxxxxxxxx>]

Daniel Holbach has proposed merging lp:~dholbach/help-app/misc-debug into lp:help-app with lp:~dholbach/help-app/1433525 as a prerequisite.

Commit message:
Add --inspector arg for ubuntu-html5-app-launcher to DEBUG=1 case in Makefile, document it and pelican's more verbose output.

Requested reviews:
  Ubuntu Help app developers (help-app-dev)

For more details, see:
https://code.launchpad.net/~dholbach/help-app/misc-debug/+merge/259011

Add --inspector arg for ubuntu-html5-app-launcher to DEBUG=1 case in Makefile, document it and pelican's more verbose output.
-- 
Your team Ubuntu Help app developers is requested to review the proposed merge of lp:~dholbach/help-app/misc-debug into lp:help-app.

=== modified file 'HACKING'
--- HACKING	2015-05-13 15:15:10 +0000
+++ HACKING	2015-05-13 15:15:10 +0000
@@ -163,6 +163,23 @@
 
 	make check
 
+Debugging
+---------
+
+Did you find a bug and you're not sure how to debug it? 
+
+Adding DEBUG=1 to the make command will give you additional information
+in a few cases. For example will 
+
+ - pelican print out debug information, which is very useful if you
+   are changing pelican configuration options or are playing around
+   with markdown extensions.
+ - 'make launch' will add the --inspector argument to 
+   ubuntu-html5-app-launcher. This will allow you to point your webkit-
+   enabled browser to  http://<yourip>:9221  to examine some of the 
+   web attributes of the app.
+  
+
 Running the app on a phone
 --------------------------
 

=== modified file 'Makefile'
--- Makefile	2015-03-31 08:24:35 +0000
+++ Makefile	2015-05-13 15:15:10 +0000
@@ -1,6 +1,7 @@
 PY?=python
 PELICAN?=pelican
 PELICANOPTS=
+APP_ARGS=
 
 BASEDIR=$(CURDIR)
 INTERNALS_DIR=$(BASEDIR)/internals
@@ -21,6 +22,7 @@
 DEBUG ?= 0
 ifeq ($(DEBUG), 1)
 	PELICANOPTS += -D
+	APP_ARGS += --inspector
 endif
 
 MD_FILES=$(wildcard $(INPUTDIR)/pages/*.md)
@@ -75,7 +77,7 @@
 	cd $(APP_DIR) && click build . && mv *.click $(BASEDIR)
 
 launch: app
-	cd $(APP_DIR); `grep '^Exec' help.desktop | tail -1 | sed 's/^Exec=//' | sed 's/%.//'` &
+	cd $(APP_DIR); `grep '^Exec' help.desktop | tail -1 | sed 's/^Exec=//' | sed 's/%.//'` $(APP_ARGS) &
 
 update-pot:
 	cd $(INTERNALS_DIR) && ./generate-pot

=== modified file 'internals/pelicanconf.py'
--- internals/pelicanconf.py	2015-05-13 15:15:10 +0000
+++ internals/pelicanconf.py	2015-05-13 15:15:10 +0000
@@ -54,7 +54,8 @@
 TAG_SAVE_AS = ''
 THEME = TOP_LEVEL_DIR+'static/themes/app/'
 
-MD_EXTENSIONS = ['local.q-and-a', 'local.external-links', 'attr_list', 'toc']
+MD_EXTENSIONS = ['local.q-and-a', 'local.external-links',
+                 'attr_list', 'toc']
 
 META_TAGS = [
     '[TOC]',