← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

Re: [Merge] lp:~verzegnassi-stefano/ubuntu-docviewer-app/advanced-text-editor into lp:ubuntu-docviewer-app

 

Review: Needs Fixing

This is looking great for viewing small text files.

A few issues:-

* "Large" text files can lock up / crash the app. By "large" I mean 910kB such as https://www.gutenberg.org/cache/epub/48984/pg48984.txt

* First line number gets messed up with large files http://people.canonical.com/~alan/screenshots/device-2015-05-18-142938.png

* Edits don't get saved. If I create a small file (using vim/nano) then edit it in docviewer, and go back, the changes don't get saved to disk.
-- 
https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/advanced-text-editor/+merge/257943
Your team Ubuntu Document Viewer Developers is subscribed to branch lp:ubuntu-docviewer-app.


References