← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~nik90/ubuntu-clock-app/fix-empty-state-warnings into lp:ubuntu-clock-app

 

The proposal to merge lp:~nik90/ubuntu-clock-app/fix-empty-state-warnings into lp:ubuntu-clock-app has been updated.

Description changed to:

Fixed empty state component warning "file:///opt/click.ubuntu.com/com.ubuntu.clock/3.3./share/qml/components/EmptyState.qml:36: TypeError: Cannot read property of null" which was caused due to parent being null when the loader is unloaded.

This was fixed by removing width: parent.width since the component automatically fills the width and height of the loader and as such doesn't require an explicit declaration of size within the component itself.

Note: I also added the debian changelog entry for a previous MP that was missing it.

For more details, see:
https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-empty-state-warnings/+merge/260173
-- 
Your team Ubuntu Clock Developers is requested to review the proposed merge of lp:~nik90/ubuntu-clock-app/fix-empty-state-warnings into lp:ubuntu-clock-app.


Follow ups