ubuntu-touch-coreapps-reviewers team mailing list archive

[Michael Zanetti <michael.zanetti@xxxxxxxxxxxxx>]

Review: Needs Fixing



Diff comments:

> === modified file 'com.ubuntu.reminders.desktop.in.in'
> --- com.ubuntu.reminders.desktop.in.in	2014-09-28 08:31:38 +0000
> +++ com.ubuntu.reminders.desktop.in.in	2015-03-20 11:17:24 +0000
> @@ -1,6 +1,6 @@
>  [Desktop Entry]
> -_Name=Reminders
> -_Comment=Ubuntu Reminders app, powered by Evernote
> +_Name=Notes
> +_Comment=Ubuntu Notes app, powered by Evernote
>  Exec=@EXEC@
>  Icon=@ICON@
>  Terminal=false
> 
> === modified file 'com.ubuntu.reminders_reminders.application.in'
> --- com.ubuntu.reminders_reminders.application.in	2014-09-24 15:02:10 +0000
> +++ com.ubuntu.reminders_reminders.application.in	2015-03-20 11:17:24 +0000
> @@ -1,7 +1,7 @@
>  <?xml version="1.0" encoding="UTF-8" ?>
>  <application id="@PROJECT_NAME@_@APP_NAME@">
>  
> -  <description>Reminders</description>
> +  <description>Notes</description>
>  
>    <services>
>      <service id="com.ubuntu.reminders_reminders">
> 
> === modified file 'debian/control'
> --- debian/control	2014-12-16 22:35:59 +0000
> +++ debian/control	2015-03-20 11:17:24 +0000
> @@ -34,7 +34,7 @@
>           suru-icon-theme | ubuntu-mobile-icons,
>           ${misc:Depends},
>           ${shlibs:Depends}
> -Description: Reminders application
> +Description: Notes application
>   Note taking application powered by Evernote
>  
>  Package: qtdeclarative5-evernote0.1
> @@ -79,5 +79,5 @@
>           reminders-app (>= ${source:Version}),
>           ubuntu-ui-toolkit-autopilot,
>           ${misc:Depends}
> -Description: Test package for the Reminders app
> - Autopilot tests for the Reminders app package
> +Description: Test package for the Notes app
> + Autopilot tests for the Notes app package
> 
> === modified file 'manifest.json.in'
> --- manifest.json.in	2015-02-12 20:34:11 +0000
> +++ manifest.json.in	2015-03-20 11:17:24 +0000
> @@ -1,5 +1,5 @@
>  {
> -    "description": "Ubuntu Reminders app, powered by Evernote",
> +    "description": "Ubuntu Notes app, powered by Evernote",
>      "framework": "ubuntu-sdk-14.10",
>      "architecture": "@CLICK_ARCH@",
>      "hooks": {
> @@ -21,7 +21,7 @@
>      },
>      "maintainer": "Ubuntu App Cats <ubuntu-touch-coreapps@xxxxxxxxxxxxxxxxxxx>",
>      "name": "com.ubuntu.reminders",
> -    "title": "Reminders",
> +    "title": "Notes",
>      "version": "0.5.@BZR_REVNO@",
>      "x-source": {
>          "vcs-bzr": "lp:reminders-app",
> 
> === modified file 'src/app/qml/reminders.qml'
> --- src/app/qml/reminders.qml	2015-03-08 18:47:51 +0000
> +++ src/app/qml/reminders.qml	2015-03-20 11:17:24 +0000
> @@ -517,7 +517,7 @@
>              }
>  
>              Tab {
> -                title: i18n.tr("Reminders")
> +                title: i18n.tr("Notes")

Heh. Nope, not this one :)

>                  page: RemindersPage {
>                      id: remindersPage
>  
> 


-- 
https://code.launchpad.net/~popey/reminders-app/fix-1434500/+merge/253651
Your team Ubuntu Reminders app developers is subscribed to branch lp:reminders-app.