← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~nik90/ubuntu-calculator-app/improve-ui into lp:ubuntu-calculator-app

 

Nekhelesh Ramananthan has proposed merging lp:~nik90/ubuntu-calculator-app/improve-ui into lp:ubuntu-calculator-app.

Commit message:
Reduced keyboard button border width and removed bold font.

Requested reviews:
  Ubuntu Calculator Developers (ubuntu-calculator-dev)

For more details, see:
https://code.launchpad.net/~nik90/ubuntu-calculator-app/improve-ui/+merge/260404

According to the design spec at https://docs.google.com/presentation/d/1EiIELGizPHrd0TY7JdNwULbiqPYfOyEEI5CS87n7QlY/edit#slide=id.g7b40fb504_00, the button border width and font are lighter than what is currently defined. This MP fixes this.
-- 
Your team Ubuntu Calculator Developers is requested to review the proposed merge of lp:~nik90/ubuntu-calculator-app/improve-ui into lp:ubuntu-calculator-app.
=== added file '.bzrignore'
--- .bzrignore	1970-01-01 00:00:00 +0000
+++ .bzrignore	2015-05-28 00:08:16 +0000
@@ -0,0 +1,2 @@
+*.user
+builddir

=== modified file 'app/ui/KeyboardButton.qml'
--- app/ui/KeyboardButton.qml	2015-04-10 22:32:41 +0000
+++ app/ui/KeyboardButton.qml	2015-05-28 00:08:16 +0000
@@ -45,7 +45,7 @@
     Rectangle {
         anchors.fill: parent
         border.color: "#d0d0d0"
-        border.width: units.dp(2)
+        border.width: units.dp(0.5)
         color: buttonRect.pressed || buttonRect.kbdPressed ? pressedColor : buttonColor
 
         Behavior on color {
@@ -60,7 +60,6 @@
         anchors.centerIn: parent
         color: "#5a5a5c"
         font.pixelSize: 0.5 * parent.height
-        font.bold: true
 
         styleColor: "gray"
     }


Follow ups