← Back to team overview

ubuntu-touch-coreapps-reviewers team mailing list archive

[Merge] lp:~popey/ubuntu-terminal-app/fix-1459437 into lp:ubuntu-terminal-app

 

Alan Pope  has proposed merging lp:~popey/ubuntu-terminal-app/fix-1459437 into lp:ubuntu-terminal-app.

Commit message:
Fix 1459437

Requested reviews:
  Ubuntu Terminal Developers (ubuntu-terminal-dev)
Related bugs:
  Bug #1459437 in Ubuntu Terminal App: "Enter key missing in SRC"
  https://bugs.launchpad.net/ubuntu-terminal-app/+bug/1459437

For more details, see:
https://code.launchpad.net/~popey/ubuntu-terminal-app/fix-1459437/+merge/260808

This adds the "Enter" key next to the arrows in the scroll keyboard layout to make it easier to "up arrow, enter" to repeat commands without having to open the OSK.
-- 
Your team Ubuntu Terminal Developers is requested to review the proposed merge of lp:~popey/ubuntu-terminal-app/fix-1459437 into lp:ubuntu-terminal-app.
=== modified file 'src/app/qml/KeyboardRows/Layouts/ScrollKeys.json'
--- src/app/qml/KeyboardRows/Layouts/ScrollKeys.json	2015-02-03 21:43:38 +0000
+++ src/app/qml/KeyboardRows/Layouts/ScrollKeys.json	2015-06-02 09:50:16 +0000
@@ -48,6 +48,13 @@
         {
             "main_action" : {
                 "type": "key",
+                "text" : "ENTER",
+                "key" : "Enter"
+            }
+        },
+        {
+            "main_action" : {
+                "type": "key",
                 "text" : "\u2191",
                 "key" : "Up"
             }


References